use --install in installation tests on Windows #1310
Conversation
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
from
a3dfd44 to
71bfce1
Compare
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
2 times, most recently
from
07b22ab to
5f8174a
Compare
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
from
5f8174a to
429e79e
Compare
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
21 times, most recently
from
c8bb496 to
f9dd35e
Compare
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
18 times, most recently
from
a9e06d2 to
b5f178b
Compare
|
@ldorau @lukaszstolarczuk ready for re-review |
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
from
b5f178b to
ce17d11
Compare
| - name: Run tests | ||
| working-directory: ${{env.BUILD_DIR}} | ||
| run: ctest -C ${{matrix.build_type}} --output-on-failure --test-dir test | ||
| # For CMake versions < 3.22 we have to add the build directory to the PATH |
There was a problem hiding this comment.
that's actually super crazy, as I can see the same issue would be with examples... so perhaps we should handle this in CMake...? (warn users? fix the paths already in CMake...? enforce newer versions if test/examples are enabled...?)
// no need to do this in this PR - I can see you marked this as TODO in CMake 👍
There was a problem hiding this comment.
I'm not sure about the examples - they are just regular executables, so the user needs to take care of the correct PATH, as usual. This issue is related only with ctest, as it contains some 'magic' that sets up paths and runs the tests. Anyway, if we encounter more problems here, I will create a separate PR
There was a problem hiding this comment.
I think we use "ENVIRONMENT_MODIFICATION" in examples' CMake, but well... we don't execute them here, so we should be good for now
bratpiorka
force-pushed
the
rrudnick_fix_ninja
branch
2 times, most recently
from
2117a1c to
748c033
Compare
3 participants
This is a fix for the failing test_installation.py on Windows, introduced by #1285. The failures are related to the
--target installcommand, which is not properly recognized on Windows. This pull request reverts the installation command to the previous version, which uses--installfor Windows.example of passed Windows Ninja job:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/14972212328/job/42055589833?pr=1310
and Windows NMake job:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/14972212328/job/42055589878?pr=1310
full nightly run:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/15117728112