remove unused UMF_NO_*_PROVIDER compile defs #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
what's the reason behind this change? pls at least describe it a little in the commit msg |
bratpiorka
force-pushed
the
rrudnick_cleanup_cmake
branch
from
fcbb43d to
4767a75
Compare
bratpiorka
changed the title
KFilipek
approved these changes
May 15, 2025
ldorau
approved these changes
May 15, 2025
lukaszstolarczuk
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So far, we have two sets of mutually exclusive compilation definitions in our CMake:
and:
This PR removes the UMF_BUILD_NO_* definitions. Also, note that UMF_NO_DEVDAX_PROVIDER and UMF_NO_FILE_PROVIDER were never used.
Checklist