Fix checking num of targets in memspace CapacityFilter test #1331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_qemu_fix
branch
5 times, most recently
from
9bc3076 to
6a77547
Compare
bratpiorka
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the NUMA memspace capacity test to compute expected counts dynamically and adds validations for total and remaining capacities, and updates the QEMU workflow’s short-run configuration list.
- Store filtered target count in a variable and replace hardcoded expectation
- Add assertions verifying total memtarget count and that remaining capacities are below the filter
- Update
.github/workflows/reusable_qemu.ymlto usesock_8_var1_hmat.xmlin short run configs
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/memspaces/memspace_numa.cpp | Refactor capacity filter test: use num_filtered, assert total count, check remaining capacities |
| .github/workflows/reusable_qemu.yml | Change short-run short_configs element from sock_4_var1_hmat.xml to sock_8_var1_hmat.xml |
Files not reviewed (1)
- FlameGraph: Language not supported
bratpiorka
force-pushed
the
rrudnick_qemu_fix
branch
2 times, most recently
from
f5f603f to
abd713e
Compare
bratpiorka
force-pushed
the
rrudnick_qemu_fix
branch
from
abd713e to
44383b4
Compare
lplewa
approved these changes
May 26, 2025
ldorau
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix checking the number of targets in the memspace CapacityFilter test.
Additionally, test the 8-socket config in the short run suite.