Skip to content

return correct error code in create_fd_for_mmap #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaszstolarczuk merged 1 commit into from
Jun 12, 2025
Merged

return correct error code in create_fd_for_mmap #1371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/provider/provider_os_memory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ create_fd_for_mmap(const umf_os_memory_provider_params_t *in_params,
provider->shm_name)) {
LOG_ERR("invalid name of a shared memory file: %s",
in_params->shm_name);
return -1;
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
}

/* create a new shared memory file */
Expand All @@ -407,7 +407,7 @@ create_fd_for_mmap(const umf_os_memory_provider_params_t *in_params,
"memory mapping failed",
in_params->shm_name, provider->max_size_fd);
provider->shm_name[0] = '\0'; // zero shm_name
return -1;
return UMF_RESULT_ERROR_UNKNOWN;
}

LOG_DEBUG("created the shared memory file /dev/shm/%s of size %zu",
Expand Down
Loading