-
Notifications
You must be signed in to change notification settings - Fork 42
memtarget & memcapacity: tests and fixes #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memtarget & memcapacity: tests and fixes #1374
Conversation
9f69e06 to
4c22546
Compare
we have function /// \brief Creates new empty memspace, which can be populated with umfMemspaceMemtargetAdd()
/// \param hMemspace [out] handle to the newly created memspace
/// \return UMF_RESULT_SUCCESS on success or appropriate error code on failure.
///
umf_result_t umfMemspaceNew(umf_memspace_handle_t *hMemspace);|So this sentence is not true. |
in internal memspace and memtarget functions.
previously we got OUT_OF_HOST_MEMORY while removing it. Extend the testing to cover this.
4c22546 to
9087e18
Compare
Fair point. Changed. |
lplewa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Add test where you remove all targets from the memspace, and then add some.
I'll add more tests in another iteration, thx |
ifs to asserts in internal functions (i.a. to increase the coverage)umfMemspaceMemtargetRemove, when trying to remove the last target - this is aligned with other functions, e.g. when trying to create memspace withsize == 0it throws the same error