Skip to content

Conversation

@lukaszstolarczuk
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk commented Jul 11, 2025

Add the fetch_content example based on the 'basic' example.

  • on Windows test in Nightly CI job with the 'Ninja' and 'NMake Makefiles' generators.
  • on Linux in standalone examples' test.

// Continuation of #1384, with changes from my review, incl.

  • get rid of FetchContent_GetProperties
  • added extra CMake printing
  • added a short description of the example
  • run this example in nightly workflow only if the VCPKG_PATH set (with hwloc)

// nightly passing: https://github.com/lukaszstolarczuk/unified-memory-framework/actions/runs/16217653089

Add the fetch_content example based on the 'basic' example.

- on Windows test in Nightly CI job with the 'Ninja' and
  'NMake Makefiles' generators.
- on Linux in standalone examples' test.

Signed-off-by: Lukasz Dorau <[email protected]>
Co-authored-by: Łukasz Stolarczuk <[email protected]>
Copy link
Contributor

@opensource-krzysztof opensource-krzysztof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bratpiorka bratpiorka self-requested a review July 16, 2025 09:21
@bratpiorka bratpiorka merged commit fe3aea6 into oneapi-src:main Jul 17, 2025
80 checks passed
@lukaszstolarczuk lukaszstolarczuk deleted the fetch-content-example branch July 17, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants