Skip to content

Va args #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2025
Merged

Va args #1434

merged 2 commits into from
Jul 15, 2025

Conversation

lplewa
Copy link
Contributor

@lplewa lplewa commented Jul 11, 2025

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa lplewa force-pushed the va_args branch 3 times, most recently from ce38044 to fa3c433 Compare July 11, 2025 12:56
bratpiorka
bratpiorka requested changes Jul 11, 2025
View reviewed changes
@lplewa lplewa force-pushed the va_args branch 3 times, most recently from 5f3e3d2 to 878e98c Compare July 11, 2025 14:49
@lplewa lplewa marked this pull request as ready for review July 11, 2025 14:50
@lplewa lplewa requested a review from a team as a code owner July 11, 2025 14:50
@lplewa lplewa force-pushed the va_args branch 2 times, most recently from 0fe7ef7 to 7fd29db Compare July 11, 2025 15:00
bratpiorka
bratpiorka reviewed Jul 14, 2025
View reviewed changes
bratpiorka
bratpiorka reviewed Jul 14, 2025
View reviewed changes
bratpiorka
bratpiorka reviewed Jul 14, 2025
View reviewed changes
@bratpiorka bratpiorka requested a review from KFilipek July 14, 2025 07:37
@lplewa
remove CTL_LEAF_SUBTREE2
aeb1f61 
It was never really needed, as name conflict can be handled it with
__VA_ARGS__ parameter but now as by_handle handlers are in two separete files we
do not have a conflict at all.
@lplewa lplewa force-pushed the va_args branch 11 times, most recently from 52d2d63 to 8fc0a2b Compare July 15, 2025 10:28
@lplewa lplewa merged commit f38a42d into oneapi-src:main Jul 15, 2025
139 of 142 checks passed
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Jul 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@kswiecicki kswiecicki kswiecicki approved these changes

@KFilipek KFilipek Awaiting requested review from KFilipek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lplewa @bratpiorka @kswiecicki