Skip to content

load ctl defaults from env variable/file #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

load ctl defaults from env variable/file #1457

merged 1 commit into from
Jul 31, 2025

Conversation

@lplewa
Copy link
Contributor

@lplewa lplewa commented Jul 22, 2025

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa lplewa requested a review from a team as a code owner July 22, 2025 12:53
@lplewa lplewa force-pushed the ctl_env branch 14 times, most recently from f907468 to 0367963 Compare July 29, 2025 10:24
KFilipek
KFilipek reviewed Jul 29, 2025
View reviewed changes
src/memory_pool.c
LOG_ERR("Failed to get pool name");
goto err_pool_init;
}
assert(pname != NULL);
Copy link
Contributor

@KFilipek KFilipek Jul 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Pointers can be directly handled:

assert(pname);

KFilipek
KFilipek approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lplewa lplewa mentioned this pull request Jul 30, 2025
Merged
ldorau
ldorau requested changes Jul 31, 2025
View reviewed changes
@lplewa lplewa merged commit 3d836a7 into oneapi-src:main Jul 31, 2025
74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KFilipek KFilipek KFilipek approved these changes

@ldorau ldorau ldorau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lplewa @KFilipek @ldorau