Skip to content

[TEST CI] Repro of issue #1169 #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 0 additions & 72 deletions .github/workflows/pr_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,88 +17,16 @@ permissions:
packages: read

jobs:
CodeChecks:
uses: ./.github/workflows/reusable_checks.yml
FastBuild:
name: Fast builds
needs: [CodeChecks]
uses: ./.github/workflows/reusable_fast.yml
Build:
name: Basic builds
needs: [FastBuild]
uses: ./.github/workflows/reusable_basic.yml
DevDax:
needs: [FastBuild]
uses: ./.github/workflows/reusable_dax.yml
MultiNuma:
needs: [FastBuild]
uses: ./.github/workflows/reusable_multi_numa.yml
L0:
needs: [Build]
uses: ./.github/workflows/reusable_gpu.yml
with:
provider: "LEVEL_ZERO"
runner: "L0"
shared_lib: "['ON']"
L0-BMG:
needs: [Build]
uses: ./.github/workflows/reusable_gpu.yml
with:
provider: "LEVEL_ZERO"
runner: "L0-BMG"
shared_lib: "['ON']"
os: "['Ubuntu']"
CUDA:
needs: [Build]
uses: ./.github/workflows/reusable_gpu.yml
with:
provider: "CUDA"
runner: "CUDA"
shared_lib: "['ON']"
Sanitizers:
needs: [FastBuild]
uses: ./.github/workflows/reusable_sanitizers.yml
QEMU:
needs: [FastBuild]
uses: ./.github/workflows/reusable_qemu.yml
with:
short_run: true
ProxyLib:
needs: [Build]
uses: ./.github/workflows/reusable_proxy_lib.yml
Valgrind:
needs: [Build]
uses: ./.github/workflows/reusable_valgrind.yml
Coverage:
# total coverage (on upstream only)
if: github.repository == 'oneapi-src/unified-memory-framework'
needs: [Build, DevDax, L0, CUDA, MultiNuma, QEMU, ProxyLib]
uses: ./.github/workflows/reusable_coverage.yml
secrets: inherit
with:
trigger: "${{github.event_name}}"
Coverage_partial:
# partial coverage (on forks)
if: github.repository != 'oneapi-src/unified-memory-framework'
needs: [Build, QEMU, ProxyLib]
uses: ./.github/workflows/reusable_coverage.yml
CodeQL:
needs: [Build]
permissions:
contents: read
security-events: write
uses: ./.github/workflows/reusable_codeql.yml
Trivy:
needs: [Build]
permissions:
contents: read
security-events: write
uses: ./.github/workflows/reusable_trivy.yml
Compatibility:
needs: [Build]
uses: ./.github/workflows/reusable_compatibility.yml
strategy:
matrix:
tag: ["v1.0.0"]
with:
tag: ${{matrix.tag}}
59 changes: 10 additions & 49 deletions .github/workflows/reusable_gpu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ on:
os:
description: A list of OSes
type: string
default: "['Ubuntu', 'Windows']"
default: "['Ubuntu']"
shared_lib:
description: A list of options for building shared library
type: string
Expand Down Expand Up @@ -129,19 +129,16 @@ jobs:

- name: Run tests (Debug)
working-directory: ${{env.BUILD_DEBUG_DIR}}
run: ctest -C Debug --output-on-failure --test-dir test
# run: for i in {1..100}; do echo ">>> ITERATION no. ${i}" ; UMF_LOG="level:debug;flush:debug;output:stderr;pid:yes" ./test/test_provider_level_zero_dlopen_global || exit 1; date; done
run: for i in {1..100}; do echo ">>> ITERATION no. ${i}" ; UMF_LOG="level:debug;flush:debug;output:stderr;pid:yes" ctest -V -R provider_level_zero || exit 1; date; done

- name: Run examples (Debug)
working-directory: ${{env.BUILD_DEBUG_DIR}}
run: ctest --output-on-failure --test-dir examples -C Debug

- name: Configure build (Release)
- name: Configure build (RelWithDebInfo)
run: >
cmake
-DCMAKE_PREFIX_PATH="${{env.VCPKG_PATH}};${{env.EXTRA_CMAKE_PATH}}"
-B ${{env.BUILD_RELEASE_DIR}}
-DCMAKE_INSTALL_PREFIX="${{env.INSTL_RELEASE_DIR}}"
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_BUILD_TYPE=RelWithDebInfo
-DCMAKE_C_COMPILER=${{env.C_COMPILER}}
-DCMAKE_CXX_COMPILER=${{env.CXX_COMPILER}}
-DUMF_BUILD_SHARED_LIBRARY=${{matrix.shared_library}}
Expand All @@ -158,46 +155,10 @@ jobs:
-DUMF_TESTS_FAIL_ON_SKIP=ON
${{ matrix.os == 'Windows' && '-DCMAKE_SUPPRESS_REGENERATION=ON' || '' }}

- name: Build UMF (Release)
run: cmake --build ${{env.BUILD_RELEASE_DIR}} --config Release -j ${{env.PROCS}}

- name: Run tests (Release)
working-directory: ${{env.BUILD_RELEASE_DIR}}
run: ctest -C Release --output-on-failure --test-dir test

- name: Run examples (Release)
working-directory: ${{env.BUILD_RELEASE_DIR}}
run: ctest --output-on-failure --test-dir examples -C Release
- name: Build UMF (RelWithDebInfo)
run: cmake --build ${{env.BUILD_RELEASE_DIR}} --config RelWithDebInfo -j ${{env.PROCS}}

- name: Run benchmarks (Release)
- name: Run tests (RelWithDebInfo)
working-directory: ${{env.BUILD_RELEASE_DIR}}
run: ctest --output-on-failure --test-dir benchmark -C Release --exclude-regex umf-multithreaded

- name: "[Lin] Check coverage (Debug)"
if: ${{ matrix.os == 'Ubuntu' }}
working-directory: ${{env.BUILD_DEBUG_DIR}}
run: |
export COVERAGE_FILE_NAME=${{env.COVERAGE_NAME}}-shared-${{matrix.shared_library}}
echo "COVERAGE_FILE_NAME: $COVERAGE_FILE_NAME"
${{github.workspace}}/scripts/coverage/coverage_capture.sh $COVERAGE_FILE_NAME
mkdir -p ${{env.COVERAGE_DIR}}
mv ./$COVERAGE_FILE_NAME ${{env.COVERAGE_DIR}}

- name: "[Lin] Upload coverage"
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
if: ${{ matrix.os == 'Ubuntu' }}
with:
name: ${{env.COVERAGE_NAME}}-shared-${{matrix.shared_library}}
path: ${{env.COVERAGE_DIR}}

- name: "[Win] Prepare vcpkg cache"
if: matrix.os == 'Windows' && steps.cache.outputs.cache-hit != 'true'
run: |
Compress-Archive -Path ${{github.workspace}}/vcpkg/packages -DestinationPath ${{github.workspace}}/vcpkg_pkgs_cache.zip -Force -CompressionLevel Fastest

- name: "[Win] Save vcpkg cache"
if: matrix.os == 'Windows' && steps.cache.outputs.cache-hit != 'true'
uses: actions/cache/save@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
with:
path: ${{github.workspace}}/vcpkg_pkgs_cache.zip
key: ${{ steps.cache.outputs.cache-primary-key }}
# run: for i in {1..1000}; do echo ">>> ITERATION no. ${i}" ; UMF_LOG="level:debug;flush:debug;output:stderr;pid:yes" ./test/test_provider_level_zero_dlopen_global || exit 1; date; done
run: for i in {1..1000}; do echo ">>> ITERATION no. ${i}" ; UMF_LOG="level:debug;flush:debug;output:stderr;pid:yes" ctest -V -R provider_level_zero || exit 1; date; done
11 changes: 11 additions & 0 deletions src/provider/provider_level_zero.c
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <assert.h>
#include <stdbool.h>
#include <stddef.h>
#include <stdint.h>
#include <string.h>

#include <umf.h>
Expand Down Expand Up @@ -753,6 +754,7 @@ static umf_result_t ze_memory_provider_allocation_split(void *provider,

typedef struct ze_ipc_data_t {
int pid;
uint64_t id; // Unique identifier for the IPC handle
ze_ipc_mem_handle_t ze_handle;
} ze_ipc_data_t;

Expand All @@ -770,6 +772,8 @@ static umf_result_t ze_memory_provider_get_ipc_handle(void *provider,
void *providerIpcData) {
(void)size;

static uint64_t id = 0;

ze_result_t ze_result;
ze_ipc_data_t *ze_ipc_data = (ze_ipc_data_t *)providerIpcData;
struct ze_memory_provider_t *ze_provider =
Expand All @@ -783,6 +787,10 @@ static umf_result_t ze_memory_provider_get_ipc_handle(void *provider,
}

ze_ipc_data->pid = utils_getpid();
ze_ipc_data->id = id++;

LOG_DEBUG("GET handle(): pid = %d, id = %lu", ze_ipc_data->pid,
ze_ipc_data->id);

return UMF_RESULT_SUCCESS;
}
Expand All @@ -801,6 +809,9 @@ static umf_result_t ze_memory_provider_put_ipc_handle(void *provider,
return UMF_RESULT_SUCCESS;
}

LOG_DEBUG("PUT handle(): pid = %d, id = %lu", ze_ipc_data->pid,
ze_ipc_data->id);

ze_result = g_ze_ops.zeMemPutIpcHandle(ze_provider->context,
ze_ipc_data->ze_handle);
if (ze_result != ZE_RESULT_SUCCESS) {
Expand Down