Skip to content

[CMake] Fail early in configure, if autoreconf is missing #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

[CMake] Fail early in configure, if autoreconf is missing #1505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,8 @@ if(UMF_LINK_HWLOC_STATICALLY)
endif()

message(
STATUS "Will fetch hwloc from ${UMF_HWLOC_REPO} (tag: ${UMF_HWLOC_TAG})"
STATUS
"Will fetch hwloc from ${UMF_HWLOC_REPO} (tag: ${UMF_HWLOC_TAG}) and link it statically"
)

if(WINDOWS)
Expand Down Expand Up @@ -309,6 +310,14 @@ if(UMF_LINK_HWLOC_STATICALLY)
set(LIBHWLOC_INCLUDE_DIRS ${hwloc_targ_BINARY_DIR}/include)
set(LIBHWLOC_FOUND TRUE)
else() # not Windows
find_program(AUTORECONF_EXECUTABLE autoreconf)
if(NOT AUTORECONF_EXECUTABLE)
message(
FATAL_ERROR
"autoreconf is not installed, but it's needed in hwloc configure step. "
"Either install it, or set UMF_LINK_HWLOC_STATICALLY=OFF and install hwloc >= 2.3.0 in your system."
)
endif()
FetchContent_Declare(
hwloc_targ
GIT_REPOSITORY ${UMF_HWLOC_REPO}
Expand Down