Skip to content

Add overflow tests #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukaszstolarczuk merged 3 commits into from
Nov 12, 2024
Merged

Add overflow tests #587

lukaszstolarczuk merged 3 commits into from
Nov 12, 2024

Conversation

@PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Jul 2, 2024 •
edited by bratpiorka
Loading

Description

closes #541

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@PatKamin PatKamin requested a review from a team as a code owner July 2, 2024 08:04
@bratpiorka bratpiorka mentioned this pull request Jul 2, 2024
Closed
@PatKamin PatKamin force-pushed the integer-overflow-tests branch 3 times, most recently from 4f36fe1 to 0086875 Compare July 5, 2024 09:20
@bratpiorka bratpiorka requested a review from lplewa July 5, 2024 09:39
lplewa
lplewa requested changes Jul 5, 2024
View reviewed changes
@PatKamin PatKamin force-pushed the integer-overflow-tests branch from 0086875 to 23b6809 Compare August 14, 2024 11:35
@PatKamin PatKamin force-pushed the integer-overflow-tests branch 2 times, most recently from adf2055 to 4cb4024 Compare September 4, 2024 12:46
ldorau
ldorau requested changes Sep 4, 2024
View reviewed changes
@PatKamin PatKamin force-pushed the integer-overflow-tests branch 3 times, most recently from 8e48902 to 4d8b693 Compare October 17, 2024 13:10
ldorau
ldorau requested changes Oct 18, 2024
View reviewed changes
@PatKamin PatKamin force-pushed the integer-overflow-tests branch from 4d8b693 to 9f23051 Compare October 18, 2024 09:41
@PatKamin PatKamin requested a review from ldorau October 18, 2024 09:44
@PatKamin PatKamin force-pushed the integer-overflow-tests branch from 9f23051 to 44f8e83 Compare October 18, 2024 10:11
lukaszstolarczuk
lukaszstolarczuk reviewed Oct 18, 2024
View reviewed changes
lukaszstolarczuk
lukaszstolarczuk approved these changes Oct 18, 2024
View reviewed changes
@PatKamin PatKamin force-pushed the integer-overflow-tests branch 2 times, most recently from d9d6b96 to 1daa6b7 Compare October 21, 2024 07:00
lplewa
lplewa reviewed Oct 21, 2024
View reviewed changes
lplewa
lplewa reviewed Oct 21, 2024
View reviewed changes
@PatKamin PatKamin force-pushed the integer-overflow-tests branch from 1daa6b7 to 0e33c4e Compare October 22, 2024 11:10
@PatKamin PatKamin requested a review from lplewa October 22, 2024 11:14
lplewa
lplewa reviewed Oct 23, 2024
View reviewed changes
@PatKamin PatKamin force-pushed the integer-overflow-tests branch from 0e33c4e to bfc20a4 Compare October 23, 2024 13:45
KFilipek
KFilipek reviewed Oct 25, 2024
View reviewed changes
src/base_alloc/base_alloc_linear.c
pool_size = ALIGN_UP(pool_size, ba_os_get_page_size());
pool_size = ALIGN_UP_SAFE(pool_size, ba_os_get_page_size());
if (pool_size == 0) {
utils_mutex_unlock(&pool->metadata.lock);
Copy link
Contributor

@KFilipek KFilipek Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the Helgrind log, I believe the problem is here. Are you sure it should be done here?

Copy link
Contributor Author

@PatKamin PatKamin Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have to release the mutex before returning from this function.

@PatKamin PatKamin force-pushed the integer-overflow-tests branch 3 times, most recently from dcbb223 to 8f160d0 Compare October 30, 2024 09:55
@PatKamin PatKamin force-pushed the integer-overflow-tests branch 2 times, most recently from cf518a9 to 74af29f Compare November 8, 2024 11:48
@PatKamin
Copy link
Contributor Author

PatKamin commented Nov 8, 2024

Rebased

@PatKamin PatKamin force-pushed the integer-overflow-tests branch from 74af29f to 4859b62 Compare November 8, 2024 12:21
@lukaszstolarczuk lukaszstolarczuk merged commit ac823bb into oneapi-src:main Nov 12, 2024
75 checks passed
@PatKamin PatKamin deleted the integer-overflow-tests branch January 28, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KFilipek KFilipek KFilipek left review comments

@ldorau ldorau ldorau approved these changes

@lplewa lplewa lplewa approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add tests for integer overflow

5 participants

@PatKamin @KFilipek @ldorau @lplewa @lukaszstolarczuk