fix: substitute UT_ASSERTs with asserts from GTEST part 4 #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EuphoricThinking
force-pushed
the
assertspr8
branch
from
e7a5858 to
d2cf678
Compare
PatKamin
reviewed
Sep 3, 2024
EuphoricThinking
force-pushed
the
assertspr8
branch
6 times, most recently
from
67331e3 to
af13501
Compare
EuphoricThinking
force-pushed
the
assertspr8
branch
from
af13501 to
b910d72
Compare
canQuery*(...) are changed to void, since EXPECT_* and ADD_FAILURE() interefere with GTEST_SKIP() when used in a non-void helper function - tests are run in spite of labelling as skipped by the fixture. The success, failure or the need to skip the tests are determined in the function body using GTEST asserts, which set the appropriate flags for the current test. Then the flags are checked in the fixture. Ref. oneapi-src#569
EuphoricThinking
force-pushed
the
assertspr8
branch
from
b910d72 to
39cdf85
Compare
lukaszstolarczuk
approved these changes
Oct 4, 2024
PatKamin
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a part of a major fix, which will be provided in multiple files.
Ref. #569
canQuery*(...) are changed to void. The success, failure or the need to skip the tests are determined in the function body using GTEST asserts, which set the appropriate flags for the current test. The flags are checked then in the fixture. The solution is inspired by GTEST docs..
The condition using ::memspaceGetTest::IsSkipped() in memspaceProviderTest is replaced due to its ineffectiveness: it has used the method from superclass for itself, before skipping any tests.
EXPECT_* and ADD_FAILURE() interefere with GTEST_SKIP() when used in a non-void helper function - tests are run in spite of labelling as ,,skipped" by the fixture.
Description
Checklist