Do not run benchmarks in the proxy_lib CI #706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not run benchmarks in the proxy_lib CI, since it takes about 4 minutes to run the umf-bench-ubench benchmark. Benchmarks are run in a separate workflow. Signed-off-by: Lukasz Dorau <[email protected]>
lukaszstolarczuk
approved these changes
Sep 4, 2024
bratpiorka
approved these changes
Sep 4, 2024
|
Times of builds:
Before:
With this patch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not run benchmarks in the proxy_lib CI,
since it takes about 4 minutes to run
the umf-bench-ubench benchmark.
Benchmarks are run in a separate workflow.
See https://github.com/oneapi-src/unified-memory-framework/actions/runs/10696438586/job/29652522203 for an example.
Times of builds:
Before:
With this patch:
Checklist