Fix includes in memspace test fixtures #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file uses `std::find` and `std::any_of` which are part of the `<algorithm>` header, but it wasn't including it. When building with gcc 14 this caused build issues such as: ``` memspace_fixtures.hpp:204:26: error: ‘any_of’ is not a member of ‘std’ ``` With this patch adding the include building UMF with gcc 14 works fine.
bratpiorka
approved these changes
Sep 6, 2024
ldorau
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This file uses
std::findandstd::any_ofwhich are part of the<algorithm>header, but it wasn't including it.When building with gcc 14 this caused build issues such as:
With this patch adding the include building UMF with gcc 14 works fine.
Checklist