Skip to content

Fix Coverity issues in RAVL tree #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix Coverity issues in RAVL tree #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ravl/ravl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,10 @@ static int ravl_node_rank(struct ravl_node *n) {
*/
static int ravl_node_rank_difference_parent(struct ravl_node *p,
struct ravl_node *n) {
return ravl_node_rank(p) - ravl_node_rank(n);
int rv = ravl_node_rank(p) - ravl_node_rank(n);
// assert to check integer overflow
assert(rv < ravl_node_rank(p));
return rv;
}

/*
Expand Down Expand Up @@ -330,6 +333,7 @@ static void ravl_balance(struct ravl *ravl, struct ravl_node *n) {
ravl_rotate(ravl, z);
ravl_node_promote(z);
ravl_node_demote(n);
assert(y != NULL);
ravl_node_demote(y);
}
}
Expand Down
Loading