Skip to content

Fix assert in ravl_node_rank_difference_parent() #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Fix assert in ravl_node_rank_difference_parent() #720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/ravl/ravl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ static int ravl_node_rank_difference_parent(struct ravl_node *p,
struct ravl_node *n) {
int rv = ravl_node_rank(p) - ravl_node_rank(n);
// assert to check integer overflow
assert(rv < ravl_node_rank(p));
// ravl_node_rank(x) is >= -1
assert(rv <= ravl_node_rank(p) + 1);
return rv;
}

Expand Down
Loading