Add the jemalloc_coarse_file and scalable_coarse_file tests #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
ldorau
force-pushed
the
Add_the_jemalloc_coarse_file_and_scalable_coarse_file_tests
branch
from
5cf11e3 to
88ffac9
Compare
Signed-off-by: Lukasz Dorau <[email protected]>
Add the jemalloc_coarse_file and scalable_coarse_file tests that test the coarse provider with upstream file provider and two pool managers: jemalloc and scalable pool. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_the_jemalloc_coarse_file_and_scalable_coarse_file_tests
branch
from
88ffac9 to
9c91404
Compare
Contributor
Author
|
PR is ready for review! |
Contributor
Author
https://github.com/oneapi-src/unified-memory-framework/actions/runs/11446838185 |
bratpiorka
approved these changes
Oct 22, 2024
PatKamin
approved these changes
Oct 22, 2024
| using umf_test::test; | ||
| using namespace umf_test; | ||
|
|
||
| #define FILE_PATH ((char *)"/tmp/file_provider") |
Contributor
There was a problem hiding this comment.
why hard-coding this path? can't we use something like for dax (UMF_TESTS_FSDAX_PATH)?
Contributor
Author
There was a problem hiding this comment.
ops, race condition ;-)
ldorau
deleted the
Add_the_jemalloc_coarse_file_and_scalable_coarse_file_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the jemalloc_coarse_file and scalable_coarse_file tests
that test the coarse provider with upstream file provider
and two pool managers: jemalloc and scalable pool.
Requires:
umfPoolTestfixture #808Checklist