Skip to content

Add missing base tests for providers #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add missing base tests for providers #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions test/memoryProviderAPI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,39 @@ TEST_F(test, memoryProviderOpsNullAllocationSplitAllocationMergeFields) {
umfMemoryProviderDestroy(hProvider);
}

TEST_F(test, memoryProviderOpsNullAllIPCFields) {
umf_memory_provider_ops_t provider_ops = UMF_NULL_PROVIDER_OPS;
provider_ops.ipc.get_ipc_handle_size = nullptr;
provider_ops.ipc.get_ipc_handle = nullptr;
provider_ops.ipc.put_ipc_handle = nullptr;
provider_ops.ipc.open_ipc_handle = nullptr;
provider_ops.ipc.close_ipc_handle = nullptr;

umf_memory_provider_handle_t hProvider;
auto ret = umfMemoryProviderCreate(&provider_ops, nullptr, &hProvider);
ASSERT_EQ(ret, UMF_RESULT_SUCCESS);

size_t size;
ret = umfMemoryProviderGetIPCHandleSize(hProvider, &size);
ASSERT_EQ(ret, UMF_RESULT_ERROR_NOT_SUPPORTED);

void *ptr = nullptr;
void *providerIpcData = nullptr;
ret = umfMemoryProviderGetIPCHandle(hProvider, ptr, size, providerIpcData);
ASSERT_EQ(ret, UMF_RESULT_ERROR_NOT_SUPPORTED);

ret = umfMemoryProviderPutIPCHandle(hProvider, providerIpcData);
ASSERT_EQ(ret, UMF_RESULT_ERROR_NOT_SUPPORTED);

ret = umfMemoryProviderOpenIPCHandle(hProvider, providerIpcData, &ptr);
ASSERT_EQ(ret, UMF_RESULT_ERROR_NOT_SUPPORTED);

ret = umfMemoryProviderCloseIPCHandle(hProvider, ptr, size);
ASSERT_EQ(ret, UMF_RESULT_ERROR_NOT_SUPPORTED);

umfMemoryProviderDestroy(hProvider);
}

////////////////// Negative test cases /////////////////

TEST_F(test, memoryProviderCreateNullOps) {
Expand Down Expand Up @@ -256,6 +289,37 @@ TEST_F(test, memoryProviderOpsNullCloseIpcHandle) {
ASSERT_EQ(ret, UMF_RESULT_ERROR_INVALID_ARGUMENT);
}

TEST_F(test, memoryProviderOpsNullAllocationSplitAllocationMergeNegative) {
umf_memory_provider_ops_t provider_ops = UMF_NULL_PROVIDER_OPS;
umf_memory_provider_handle_t hProvider;

auto ret = umfMemoryProviderCreate(&provider_ops, nullptr, &hProvider);
ASSERT_EQ(ret, UMF_RESULT_SUCCESS);

ret = umfMemoryProviderAllocationSplit(hProvider, nullptr, 2 * 4096, 4096);
ASSERT_EQ(ret, UMF_RESULT_ERROR_INVALID_ARGUMENT);

ret =
umfMemoryProviderAllocationMerge(hProvider, nullptr, nullptr, 2 * 4096);
ASSERT_EQ(ret, UMF_RESULT_ERROR_INVALID_ARGUMENT);

void *lowPtr = (void *)0xBAD;
void *highPtr = (void *)((uintptr_t)lowPtr + 4096);
size_t totalSize = 0;
ret =
umfMemoryProviderAllocationMerge(hProvider, lowPtr, highPtr, totalSize);
ASSERT_EQ(ret, UMF_RESULT_ERROR_INVALID_ARGUMENT);

totalSize = 4096;
lowPtr = (void *)0xBAD;
highPtr = (void *)((uintptr_t)lowPtr + 2 * totalSize);
ret =
umfMemoryProviderAllocationMerge(hProvider, lowPtr, highPtr, totalSize);
ASSERT_EQ(ret, UMF_RESULT_ERROR_INVALID_ARGUMENT);

umfMemoryProviderDestroy(hProvider);
}

struct providerInitializeTest : umf_test::test,
::testing::WithParamInterface<umf_result_t> {};

Expand Down
Loading