Add additional tests for CUDA and L0 providers #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
force-pushed
the
svinogra_gpu_tests
branch
from
a0614d2 to
f9177a2
Compare
vinser52
force-pushed
the
svinogra_gpu_tests
branch
from
f9177a2 to
d777eb2
Compare
bratpiorka
reviewed
Oct 23, 2024
ldorau
requested changes
Oct 23, 2024
ldorau
approved these changes
Oct 23, 2024
Contributor
ldorau
left a comment
ldorau
left a comment
There was a problem hiding this comment.
Could you add tests for
cu_memory_provider_get_last_native_erroreither?cu_memory_provider_get_last_native_errorandcu_store_last_native_errorare not used at all.
It can be in a separate (next) PR if you prefer.
vinser52
force-pushed
the
svinogra_gpu_tests
branch
from
d777eb2 to
e524922
Compare
Contributor
Author
Yeah, better to add them in a separate PR. Need to think about the scenario when CUDA provider returns provider-specific error. |
lukaszstolarczuk
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To improve code coverage the new tests for CUDA and L0 providers are added. In next PR this tests can be refactored to avoid code duplications.
Checklist