Skip to content

Use std::vector<char> instead of std::unique_ptr<char[]> #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Use std::vector<char> instead of std::unique_ptr<char[]> #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/disjointCoarseMallocPool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,11 +395,10 @@ TEST_P(CoarseWithMemoryStrategyTest, disjointCoarseMMapPool_random) {

const size_t init_buffer_size = 200 * MB;

// Preallocate some memory
std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
void *buf = buffer.get();
// preallocate some memory and initialize the vector with zeros
std::vector<char> buffer(init_buffer_size, 0);
void *buf = (void *)buffer.data();
ASSERT_NE(buf, nullptr);
memset(buf, 0, init_buffer_size);

const unsigned char alloc_check_val = 11;

Expand Down
35 changes: 15 additions & 20 deletions test/provider_coarse.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,10 @@ TEST_F(test, coarseProvider_name_no_upstream) {

const size_t init_buffer_size = 20 * MB;

// Preallocate some memory
std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
void *buf = buffer.get();
// preallocate some memory and initialize the vector with zeros
std::vector<char> buffer(init_buffer_size, 0);
void *buf = (void *)buffer.data();
ASSERT_NE(buf, nullptr);
memset(buf, 0, init_buffer_size);

coarse_memory_provider_params_t coarse_memory_provider_params;
// make sure there are no undefined members - prevent a UB
Expand Down Expand Up @@ -159,11 +158,10 @@ TEST_P(CoarseWithMemoryStrategyTest, coarseProvider_wrong_params_1) {

const size_t init_buffer_size = 20 * MB;

// Preallocate some memory
std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
void *buf = buffer.get();
// preallocate some memory and initialize the vector with zeros
std::vector<char> buffer(init_buffer_size, 0);
void *buf = (void *)buffer.data();
ASSERT_NE(buf, nullptr);
memset(buf, 0, init_buffer_size);

coarse_memory_provider_params_t coarse_memory_provider_params;
// make sure there are no undefined members - prevent a UB
Expand Down Expand Up @@ -223,11 +221,10 @@ TEST_P(CoarseWithMemoryStrategyTest, coarseProvider_wrong_params_3) {

const size_t init_buffer_size = 20 * MB;

// Preallocate some memory
std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
void *buf = buffer.get();
// preallocate some memory and initialize the vector with zeros
std::vector<char> buffer(init_buffer_size, 0);
void *buf = (void *)buffer.data();
ASSERT_NE(buf, nullptr);
memset(buf, 0, init_buffer_size);

coarse_memory_provider_params_t coarse_memory_provider_params;
// make sure there are no undefined members - prevent a UB
Expand Down Expand Up @@ -284,11 +281,10 @@ TEST_P(CoarseWithMemoryStrategyTest, coarseProvider_wrong_params_5) {

const size_t init_buffer_size = 20 * MB;

// Preallocate some memory
std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
void *buf = buffer.get();
// preallocate some memory and initialize the vector with zeros
std::vector<char> buffer(init_buffer_size, 0);
void *buf = (void *)buffer.data();
ASSERT_NE(buf, nullptr);
memset(buf, 0, init_buffer_size);

coarse_memory_provider_params_t coarse_memory_provider_params;
// make sure there are no undefined members - prevent a UB
Expand Down Expand Up @@ -521,11 +517,10 @@ TEST_P(CoarseWithMemoryStrategyTest, coarseProvider_purge_no_upstream) {

const size_t init_buffer_size = 20 * MB;

// Preallocate some memory
std::unique_ptr<char[]> buffer(new char[init_buffer_size]);
void *buf = buffer.get();
// preallocate some memory and initialize the vector with zeros
std::vector<char> buffer(init_buffer_size, 0);
void *buf = (void *)buffer.data();
ASSERT_NE(buf, nullptr);
memset(buf, 0, init_buffer_size);

coarse_memory_provider_params_t coarse_memory_provider_params;
// make sure there are no undefined members - prevent a UB
Expand Down
Loading