[main] Fix disabling of pci support in hwloc #866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
could you write more why we disable this? Maybe we should review the full list of flags and disable more? |
The flag that hwloc recognize is --disable-pci, not --disable-pciaccess.
PatKamin
force-pushed
the
disable-libudev
branch
from
611ad61 to
2732eb4
Compare
PatKamin
changed the title
Contributor
Author
Minimized the changes to current flag fix, with explanation. |
bratpiorka
approved these changes
Nov 6, 2024
kswiecicki
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag that hwloc recognize is --disable-pci, not --disable-pciaccess.