Fix os_get_ipc_handle() - add protection and visibility #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add protection and visibility to the IPC handle. Fix `os_get_ipc_handle()` - get protection and visibility from the IPC handle instead of provider. Signed-off-by: Lukasz Dorau <[email protected]>
PatKamin
approved these changes
Nov 6, 2024
vinser52
approved these changes
Nov 6, 2024
bratpiorka
reviewed
Nov 6, 2024
| *ptr = utils_mmap(NULL, os_ipc_data->size, os_provider->protection, | ||
| os_provider->visibility, fd, os_ipc_data->fd_offset); | ||
| *ptr = utils_mmap(NULL, os_ipc_data->size, os_ipc_data->protection, | ||
| os_ipc_data->visibility, fd, os_ipc_data->fd_offset); |
Contributor
There was a problem hiding this comment.
Could you add a test to check the expected properties of the mapped memory retrieved from the IPC handle?
ldorau
deleted the
Fix_os_get_ipc_handle_-_add_protection_and_visibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add protection and visibility to the IPC handle.
Fix
os_get_ipc_handle()- get protection and visibility from the IPC handle instead of provider.Checklist