Skip to content

Conversation

@PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Nov 6, 2024

Description

Less steps in a build example in README:

  • do not mix usage of make and cmake, cmake handles all that is needed
  • cmake handles build dir creation

Preview: https://github.com/PatKamin/unified-memory-framework/tree/simplify-build-steps?tab=readme-ov-file#linux

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@PatKamin PatKamin requested a review from a team as a code owner November 6, 2024 12:04
- do not mix usage of make and cmake, cmake handles all that is needed
- cmake handles build dir creation
@PatKamin PatKamin force-pushed the simplify-build-steps branch from 7394070 to 86c18c8 Compare November 6, 2024 14:30
@lukaszstolarczuk lukaszstolarczuk merged commit a352cf7 into oneapi-src:main Nov 6, 2024
4 of 21 checks passed
@PatKamin PatKamin deleted the simplify-build-steps branch January 28, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants