Skip to content

Fix umf_ba_free() - do not assert on unknown pointer #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix umf_ba_free() - do not assert on unknown pointer #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/base_alloc/base_alloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,11 @@ void umf_ba_free(umf_ba_pool_t *pool, void *ptr) {
umf_ba_chunk_t *chunk = (umf_ba_chunk_t *)ptr;

utils_mutex_lock(&pool->metadata.free_lock);
assert(pool_contains_pointer(pool, ptr));
if (!pool_contains_pointer(pool, ptr)) {
Copy link
Contributor

@vinser52 vinser52 Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why should we remove this assert. It was able to catch the issue #903. With this PR we just disable it and issue become silent.

Copy link
Contributor Author

@ldorau ldorau Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right :-)

utils_mutex_unlock(&pool->metadata.free_lock);
return;
}

chunk->next = pool->metadata.free_list;
pool->metadata.free_list = chunk;
pool->metadata.n_allocs--;
Expand Down
Loading