Skip to content

Fix: getGlobalLruListSize() is needed only in debug mode #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Fix: getGlobalLruListSize() is needed only in debug mode #912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ipc_cache.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,14 @@
return ret;
}

#ifndef NDEBUG
static size_t getGlobalLruListSize(lru_list_t lru_list) {
size_t size = 0;
ipc_handle_cache_entry_t *tmp;
DL_COUNT(lru_list, tmp, size);
return size;
}
#endif /* NDEBUG */

void umfIpcCacheGlobalTearDown(void) {
ipc_mapped_handle_cache_global_t *cache_global = IPC_MAPPED_CACHE_GLOBAL;
Expand Down Expand Up @@ -216,7 +218,7 @@
entry->value.mapped_size = 0;
entry->value.mapped_base_ptr = NULL;

HASH_ADD(hh, cache->hash_table, key, sizeof(entry->key), entry);

Check warning on line 221 in src/ipc_cache.c

View workflow job for this annotation

GitHub Actions / Basic builds / Windows (windows-2019, Debug, cl, cl, ON, ON, ON) 

 unreachable code [D:\a\unified-memory-framework\unified-memory-framework\build\src\umf.vcxproj]

Check warning on line 221 in src/ipc_cache.c

View workflow job for this annotation

GitHub Actions / Basic builds / Windows (windows-2019, Debug, cl, cl, OFF, ON, ON) 

 unreachable code [D:\a\unified-memory-framework\unified-memory-framework\build\src\umf.vcxproj]

Check warning on line 221 in src/ipc_cache.c

View workflow job for this annotation

GitHub Actions / Basic builds / Windows (windows-2019, Release, cl, cl, ON, ON, ON) 

 unreachable code [D:\a\unified-memory-framework\unified-memory-framework\build\src\umf.vcxproj]

Check warning on line 221 in src/ipc_cache.c

View workflow job for this annotation

GitHub Actions / Basic builds / Windows (windows-2019, Release, cl, cl, OFF, ON, ON) 

 unreachable code [D:\a\unified-memory-framework\unified-memory-framework\build\src\umf.vcxproj]
DL_PREPEND(cache->global->lru_list, entry);
cache->global->cur_size += 1;
}
Expand Down
Loading