Link statically with custom jemalloc with disabled initial TLS #941

ldorau · 2024-11-27T11:13:04Z

Description

Link statically with custom jemalloc built from sources
with the following non-default options enabled:

--with-jemalloc-prefix=je_ - add je_ prefix to all public APIs
--disable-cxx - Disable C++ integration. This will cause new and delete operators implementations to be omitted.
--disable-initial-exec-tls - Disable the initial-exec TLS model for jemalloc's internal thread-local storage (on those platforms that support explicit settings). This can allow jemalloc to be dynamically loaded after program startup (e.g. using dlopen()).

Fixes: #891
Fixes: #894
Fixes: #903

Checklist

Code compiles without errors locally
All tests pass locally
CI workflows execute properly

.github/workflows/reusable_multi_numa.yml

examples/dram_and_fsdax/CMakeLists.txt

Fixed

ldorau · 2024-11-28T14:53:51Z

There is still one issue:

./benchmark/umf-bench-ubench segfaults for unknown reason on L0 only (the segfault occurs in jemalloc's je_free_default() called from the constructor of libigc.so which libze_intel_gpu.so.1 depends on) see: https://github.com/oneapi-src/unified-memory-framework/actions/runs/12069615645/job/33659028476

ldorau · 2024-11-28T14:54:51Z

There is still one issue:

./benchmark/umf-bench-ubench segfaults for unknown reason on L0 only (the segfault occurs in jemalloc's je_free_default() called from the constructor of libigc.so which libze_intel_gpu.so.1 depends on) see: https://github.com/oneapi-src/unified-memory-framework/actions/runs/12069615645/job/33659028476

I am testing the previous release of jemalloc (v5.2.1) now...

examples/CMakeLists.txt

examples/dram_and_fsdax/CMakeLists.txt

src/pool/CMakeLists.txt

CMakeLists.txt

.github/workflows/performance.yml

Signed-off-by: Lukasz Dorau <[email protected]>

Link statically with custom jemalloc built from sources with the following non-default options enabled: --with-jemalloc-prefix=je_ - add je_ prefix to all public APIs --disable-cxx - Disable C++ integration. This will cause new and delete operators implementations to be omitted. --disable-initial-exec-tls - Disable the initial-exec TLS model for jemalloc's internal thread-local storage (on those platforms that support explicit settings). This can allow jemalloc to be dynamically loaded after program startup (e.g. using dlopen). Fixes: oneapi-src#891 Fixes: oneapi-src#894 Fixes: oneapi-src#903 Signed-off-by: Lukasz Dorau <[email protected]>

vinser52 · 2024-12-04T13:27:28Z

benchmark/multithread.cpp

    // ctest looks for "PASSED" in the output
    std::cout << "PASSED" << std::endl;

+#if defined(UMF_BUILD_LIBUMF_POOL_DISJOINT)


On L124 the following macro is used: #if defined(UMF_POOL_DISJOINT_ENABLED).

Please decide which is appropriate UMF_POOL_DISJOINT_ENABLED or UMF_BUILD_LIBUMF_POOL_DISJOINT and unify

In our CMake files *_ENABLED = user set appropriate BUILD flag + all dependencies needed for build are satisfied so we actually can use given component.
@ldorau please use *_ENABLED in c/cpp files

vinser52

Please fix the remaining comment

README.md

CMakeLists.txt

.github/workflows/coverity.yml

Remove the separate static `jemalloc_pool` library. Make the `UMF_BUILD_LIBUMF_POOL_JEMALLOC` option turned ON by default. Incorporate jemalloc_pool into libumf. Signed-off-by: Lukasz Dorau <[email protected]>

benchmark/CMakeLists.txt

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch 2 times, most recently from b9c4aff to 1478d88 Compare November 27, 2024 11:15

ldorau mentioned this pull request Nov 27, 2024

[DRAFT] Load jemalloc library dynamically #919

Closed

3 tasks

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch from 1478d88 to 48145aa Compare November 27, 2024 13:26

ldorau requested review from bratpiorka and lplewa November 27, 2024 13:26

bratpiorka previously requested changes Nov 27, 2024

View reviewed changes

.github/workflows/reusable_multi_numa.yml Outdated Show resolved Hide resolved

.github/workflows/reusable_multi_numa.yml Outdated Show resolved Hide resolved

examples/dram_and_fsdax/CMakeLists.txt Outdated Show resolved Hide resolved

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch from 48145aa to b024e53 Compare November 27, 2024 14:04

ldorau requested a review from bratpiorka November 27, 2024 14:05

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch 15 times, most recently from e437bbf to fd5bd4e Compare November 28, 2024 13:14

ldorau marked this pull request as ready for review November 28, 2024 14:23

ldorau requested a review from a team as a code owner November 28, 2024 14:23

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch from fd5bd4e to ee811cb Compare November 28, 2024 14:52

ldorau requested a review from KFilipek December 4, 2024 08:17

vinser52 reviewed Dec 4, 2024

View reviewed changes

examples/CMakeLists.txt Outdated Show resolved Hide resolved

vinser52 reviewed Dec 4, 2024

View reviewed changes

examples/dram_and_fsdax/CMakeLists.txt Outdated Show resolved Hide resolved

vinser52 reviewed Dec 4, 2024

View reviewed changes

src/pool/CMakeLists.txt Outdated Show resolved Hide resolved

PatKamin reviewed Dec 4, 2024

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

PatKamin reviewed Dec 4, 2024

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch from 5298b5e to aed8c12 Compare December 4, 2024 11:45

ldorau requested review from PatKamin and vinser52 December 4, 2024 11:47

vinser52 reviewed Dec 4, 2024

View reviewed changes

.github/workflows/performance.yml Show resolved Hide resolved

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch from aed8c12 to 1a11bb9 Compare December 4, 2024 12:37

ldorau added 2 commits December 4, 2024 13:38

Disable jemalloc pool on RHEL

d8a340e

Signed-off-by: Lukasz Dorau <[email protected]>

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch from 1a11bb9 to fe7aaff Compare December 4, 2024 12:39

ldorau requested a review from vinser52 December 4, 2024 12:42

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch 3 times, most recently from 63ecc30 to 2802736 Compare December 4, 2024 13:20

vinser52 reviewed Dec 4, 2024

View reviewed changes

vinser52 approved these changes Dec 4, 2024

View reviewed changes

PatKamin approved these changes Dec 4, 2024

View reviewed changes

lukaszstolarczuk requested changes Dec 4, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch from 2802736 to cd4e7c2 Compare December 4, 2024 15:28

bratpiorka reviewed Dec 4, 2024

View reviewed changes

.github/workflows/coverity.yml Show resolved Hide resolved

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch from cd4e7c2 to 003075f Compare December 4, 2024 15:42

Incorporate jemalloc_pool into libumf

614c4b5

Remove the separate static `jemalloc_pool` library. Make the `UMF_BUILD_LIBUMF_POOL_JEMALLOC` option turned ON by default. Incorporate jemalloc_pool into libumf. Signed-off-by: Lukasz Dorau <[email protected]>

ldorau force-pushed the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch from 003075f to 614c4b5 Compare December 4, 2024 16:01

lukaszstolarczuk approved these changes Dec 5, 2024

View reviewed changes

benchmark/CMakeLists.txt Show resolved Hide resolved

ldorau merged commit 27ee09f into oneapi-src:main Dec 5, 2024
77 checks passed

ldorau deleted the Link_statically_with_custom_jemalloc_with_disabled_initial_TLS branch December 5, 2024 09:36

Link statically with custom jemalloc with disabled initial TLS #941

Link statically with custom jemalloc with disabled initial TLS #941

Uh oh!

Conversation

ldorau commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ldorau commented Nov 28, 2024

Uh oh!

ldorau commented Nov 28, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinser52 Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

bratpiorka Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

ldorau Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

vinser52 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ldorau commented Nov 27, 2024 •

edited

Loading