Minor fixes to clean up resources in tests #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
approved these changes
Dec 5, 2024
lplewa
approved these changes
Dec 5, 2024
lukaszstolarczuk
approved these changes
Dec 5, 2024
lukaszstolarczuk
requested changes
Dec 5, 2024
Contributor
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
actually, shouldn't this go to v0.10.x ...?
Contributor
this is not needed there as this only fixes tests - there is no bug in Disjoint Pool implementation .. |
Contributor
Author
|
I think it is not needed for |
Contributor
Author
|
@bratpiorka what is your final answer, should I switch target branch to |
Contributor
|
ok, that's perferct, if not found by the coverity tool, then it's ok |
lukaszstolarczuk
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor fixes to properly clean up resources when disjoint pool params functions return an error.
Checklist