Skip to content

add test dax_provider_purge_force on unalligned address #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add test dax_provider_purge_force on unalligned address #970

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb08b67
Merge pull request #958 from ldorau/Add_info_about_the_PTRACE_MODE_AT…
bratpiorka Dec 3, 2024
1cd7073
add extra test for dax provider
lplewa Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions test/provider_devdax_memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,13 @@ TEST_P(umfProviderTest, purge_force) {
test_alloc_free_success(provider.get(), page_size, 0, PURGE_FORCE);
}

TEST_P(umfProviderTest, purge_force_unalligned_alloc) {
Copy link
Contributor

@PatKamin PatKamin Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unalligned -> unaligned

Copy link
Contributor

@PatKamin PatKamin Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it that devdax malloc is always aligned?

unified-memory-framework/src/provider/provider_devdax_memory.c

Lines 281 to 284 in a08a121

if (IS_NOT_ALIGNED(alignment, DEVDAX_PAGE_SIZE_2MB)) {
alignment = ALIGN_UP(alignment, DEVDAX_PAGE_SIZE_2MB);
}

void *ptr;
auto ret = umfMemoryProviderAlloc(provider.get(), page_size / 2, 0, &ptr);
ASSERT_EQ(ret, UMF_RESULT_SUCCESS);
test_alloc_free_success(provider.get(), page_size, 0, PURGE_FORCE);
umfMemoryProviderFree(provider.get(), ptr, page_size / 2);
}
// negative tests using test_alloc_failure

TEST_P(umfProviderTest, alloc_page64_align_page_minus_1_WRONG_ALIGNMENT_1) {
Expand Down
Loading