Skip to content

Ignore return value of je_mallctl() in an error handling path #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Ignore return value of je_mallctl() in an error handling path #972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pool/pool_jemalloc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ static umf_result_t op_initialize(umf_memory_provider_handle_t provider,
err = je_mallctl(cmd, NULL, NULL, (void *)&pHooks, sizeof(void *));
if (err) {
snprintf(cmd, sizeof(cmd), "arena.%u.destroy", arena_index);
je_mallctl(cmd, NULL, 0, NULL, 0);
(void)je_mallctl(cmd, NULL, 0, NULL, 0);
LOG_ERR("Could not setup extent_hooks for newly created arena.");
goto err_free_pool;
}
Expand All @@ -528,7 +528,7 @@ static void op_finalize(void *pool) {
jemalloc_memory_pool_t *je_pool = (jemalloc_memory_pool_t *)pool;
char cmd[64];
snprintf(cmd, sizeof(cmd), "arena.%u.destroy", je_pool->arena_index);
je_mallctl(cmd, NULL, 0, NULL, 0);
(void)je_mallctl(cmd, NULL, 0, NULL, 0);
pool_by_arena_index[je_pool->arena_index] = NULL;
umf_ba_global_free(je_pool);

Expand Down
Loading