Fix: remove incorrect assert in utils_align_ptr_up_size_down() #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
do you have a test for that? 😉
Remove incorrect assert in utils_align_ptr_up_size_down(). A pointer is aligned, but a size is only adjusted to the new pointer. The size does not have to be aligned. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Remove_incorrect_assert_in_utils_align_ptr_up_size_down
branch
from
c0f247b to
b2605ba
Compare
Contributor
Author
@lukaszstolarczuk Tests added |
ldorau
requested review from
KFilipek,
bratpiorka,
kswiecicki and
lukaszstolarczuk
KFilipek
reviewed
Dec 9, 2024
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Remove_incorrect_assert_in_utils_align_ptr_up_size_down
branch
from
b2605ba to
dd47ffc
Compare
bratpiorka
approved these changes
Dec 10, 2024
Contributor
Author
|
@lukaszstolarczuk @KFilipek please re-review |
KFilipek
approved these changes
Dec 10, 2024
ldorau
deleted the
Remove_incorrect_assert_in_utils_align_ptr_up_size_down
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove incorrect assert in
utils_align_ptr_up_size_down().A pointer is aligned, but a size is only adjusted to the new pointer.
The size does not have to be aligned.
Checklist