Skip to content

Run pr_push on schedule at night to get full code coverage from QEMU #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Run pr_push on schedule at night to get full code coverage from QEMU #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/pr_push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ on:
branches-ignore:
- 'dependabot/**'
pull_request:
schedule:
- cron: '0 1 * * *'

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down Expand Up @@ -53,7 +55,7 @@ jobs:
needs: [FastBuild]
uses: ./.github/workflows/reusable_qemu.yml
with:
short_run: true
short_run: ${{ github.event_name == 'schedule' && 'false' || 'true' }}
Copy link
Contributor

@PatKamin PatKamin Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ubuntu-22.04 build from Nightly as this seems to be doubled now.

Also, shouldn't this workflow be triggered as part of a Nightly build? Now this job's results will not be as easy to find as if they were run as part of a Nightly as there are plenty of pr_push runs and only one Nightly a day.

Copy link
Contributor Author

@ldorau ldorau Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I do not want to modify Nightly.
  2. This workflow is not reusable, so AFAIK it cannot be run as a part of the Nightly build.

@lukaszstolarczuk what do you think?

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would ask a different question - did you observe a better code coverage with long QEMU run? TBH, I don't expect increase in number of covered lines.

Short run only enable more numa configs; I tried to pick a representative subset of all configs, that should cover bigger and smaller number of nodes, plus HMAT on/off. Plus it runs valgrind on all configs, not just one.

Copy link
Contributor Author

@ldorau ldorau Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would ask a different question - did you observe a better code coverage with long QEMU run? TBH, I don't expect increase in number of covered lines.

You are right :-) Closing ...

Benchmarks:
needs: [Build]
uses: ./.github/workflows/reusable_benchmarks.yml
Expand Down
Loading