Skip to content

[DEBUG CI] Nightly CI #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[DEBUG CI] Nightly CI #989

wants to merge 2 commits into from

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented Dec 11, 2024

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

lplewa and others added 2 commits December 10, 2024 16:36
@lplewa
use unique_ptr instead of constructor/destructor in benchmarks
36d134c 
On Windows static builds, destructors are invoked after the UMF destructor,
causing parameter structures to be unable to be destroyed. By switching to
std::unique_ptr, we ensure that parameters are properly cleaned up and
the destruction order issue is resolved.
@ldorau
[DEBUG CI] Nightly CI
9d141e7
@ldorau ldorau closed this Dec 11, 2024
@ldorau ldorau deleted the review_uniqe branch December 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ldorau @lplewa