Implement size limit for the cache of opened IPC handles #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
TODO: need to add tests |
Contributor
|
and probably you could add some info about this var into README, pls |
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
c12c72a to
3615b04
Compare
Contributor
Author
Sure, I will do that. |
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
3615b04 to
d7775a9
Compare
Contributor
|
@vinser52 what are the plans for this PR? Is it working and ready to review? |
Contributor
Author
It is not ready yet. I am working on it right now. Need to implement proper refcounting and eviction. |
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
d7775a9 to
49dd961
Compare
3 tasks
vinser52
force-pushed
the
svinogra_ipc_cache
branch
4 times, most recently
from
00e4b48 to
f6b00ec
Compare
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
f6b00ec to
d939f05
Compare
vinser52
commented
Feb 21, 2025
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
d939f05 to
5ba3269
Compare
Contributor
Author
@lukaszstolarczuk Done. I updated the online documentation. |
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
af4cedd to
ee16966
Compare
vinser52
force-pushed
the
svinogra_ipc_cache
branch
2 times, most recently
from
abe2ff4 to
aa8c457
Compare
ldorau
reviewed
Feb 24, 2025
ldorau
requested changes
Feb 24, 2025
ldorau
requested changes
Feb 24, 2025
vinser52
force-pushed
the
svinogra_ipc_cache
branch
3 times, most recently
from
4f58542 to
11c7f6d
Compare
ldorau
requested changes
Mar 6, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ldorau
approved these changes
Mar 6, 2025
Contributor
ldorau
left a comment
ldorau
left a comment
There was a problem hiding this comment.
LGTM except the above question
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
11c7f6d to
583973d
Compare
bratpiorka
reviewed
Mar 7, 2025
bratpiorka
reviewed
Mar 7, 2025
bratpiorka
reviewed
Mar 7, 2025
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
583973d to
89d338c
Compare
5 tasks
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
89d338c to
f072239
Compare
Contributor
|
@bratpiorka @lplewa @igchor please re-review |
KFilipek
reviewed
Mar 10, 2025
igchor
approved these changes
Mar 10, 2025
Contributor
|
@vinser52 please rebase |
vinser52
force-pushed
the
svinogra_ipc_cache
branch
from
f072239 to
5f4336d
Compare
Contributor
Author
Done |
KFilipek
approved these changes
Mar 11, 2025
bratpiorka
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is a follow-up of the #736. Add an environment variable that allows setting a limit for the size of the cache of opened IPC handles.
Checklist