Add event update to command-buffers #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
2 times, most recently
from
e27e2de to
6afed3f
Compare
github-actions
bot
added
loader
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
3 times, most recently
from
a480a67 to
4c3389f
Compare
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
2 times, most recently
from
c559851 to
938cbe4
Compare
EwanC
commented
Jul 11, 2024
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
3 times, most recently
from
e8db775 to
ddf3f10
Compare
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
3 times, most recently
from
af9b056 to
ea35fb5
Compare
aarongreig
reviewed
Aug 30, 2024
test/conformance/exp_command_buffer/event_sync_kernel_command.cpp
Outdated
Show resolved
Hide resolved
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
2 times, most recently
from
bcb101b to
98a6f5e
Compare
aarongreig
approved these changes
Sep 4, 2024
hdelan
reviewed
Sep 5, 2024
hdelan
reviewed
Sep 5, 2024
hdelan
reviewed
Sep 5, 2024
hdelan
reviewed
Sep 5, 2024
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
3 times, most recently
from
cea3086 to
28d5122
Compare
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
from
28d5122 to
1cf31c0
Compare
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
from
1cf31c0 to
f788588
Compare
EwanC
pushed a commit
to reble/llvm
that referenced
this pull request
Oct 2, 2024
PietroGhg
approved these changes
Oct 3, 2024
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
2 times, most recently
from
6550981 to
23d2720
Compare
fabiomestre
approved these changes
Oct 4, 2024
Expand the command-buffer experimental feature API so that it can be used to implement [SYCL-Graph dynamic events](reble/llvm#372). This involves extending each command append entry-point to include the following extra parameters: * An output `ur_exp_command_buffer_command_handle_t`. * An Input `ur_event_handle_t` event wait-list of dependent events. * An output `ur_event_handle_t` event that is signaled when the command completes its next execution. New entry-points are also added to update the wait-list and signal event parameters of commands: * `urCommandBufferUpdateSignalEventExp` * `urCommandBufferUpdateWaitEventsExp` APIs implemented for CUDA adapter with CTS tests.
EwanC
force-pushed
the
ewan/ur_dyn_events
branch
from
23d2720 to
0b5b89f
Compare
|
ping @oneapi-src/unified-runtime-level-zero-write for review |
pbalcer
approved these changes
Oct 7, 2024
againull
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 14, 2024
Test UR PR oneapi-src/unified-runtime#1823 --------- Co-authored-by: Aaron Greig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand the command-buffer experimental feature API so that it can be used to implement SYCL-Graph dynamic
events.
This involves extending each command append entry-point to include the following extra parameters:
ur_exp_command_buffer_command_handle_t.ur_event_handle_tevent wait-list of dependent events.ur_event_handle_tevent that is signaled when the command completes its next execution.New entry-points are also added to update the wait-list and signal event parameters of commands:
urCommandBufferUpdateSignalEventExpurCommandBufferUpdateWaitEventsExpThe UR changes are implemented for the cuda adapter only in this PR to prove the concepts, and other adapter implementations will follow as subsequent PRs to ease review.
New CTS tests are also added, see
exp_command_buffer/event_sync_kernel_command.cppandexp_command_buffer/event_sync.cppDPC++ PR intel/llvm#14459