Skip to content

[L0] Fix device query of bindless image support #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[L0] Fix device query of bindless image support #2018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions source/adapters/level_zero/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,20 +1010,28 @@ ur_result_t urDeviceGetInfo(
Device->Platform->ZeMutableCmdListExt.Supported);
}
case UR_DEVICE_INFO_BINDLESS_IMAGES_SUPPORT_EXP: {
// On L0 bindless images are supported.
return ReturnValue(true);
bool DeviceIsDG2OrNewer =
Device->ZeDeviceIpVersionExt->ipVersion >= 0x030dc000;
return ReturnValue(DeviceIsDG2OrNewer &&
Device->ZeDeviceImageProperties->maxImageDims1D > 0 &&
Device->ZeDeviceImageProperties->maxImageDims2D > 0 &&
Device->ZeDeviceImageProperties->maxImageDims3D > 0);
}
case UR_DEVICE_INFO_BINDLESS_IMAGES_SHARED_USM_SUPPORT_EXP: {
// On L0 bindless images can not be backed by shared (managed) USM.
return ReturnValue(false);
}
case UR_DEVICE_INFO_BINDLESS_IMAGES_1D_USM_SUPPORT_EXP: {
// On L0 1D bindless image USM are supported.
return ReturnValue(true);
bool DeviceIsDG2OrNewer =
Device->ZeDeviceIpVersionExt->ipVersion >= 0x030dc000;
return ReturnValue(DeviceIsDG2OrNewer &&
Device->ZeDeviceImageProperties->maxImageDims1D > 0);
}
case UR_DEVICE_INFO_BINDLESS_IMAGES_2D_USM_SUPPORT_EXP: {
// On L0 2D bindless image USM are supported.
return ReturnValue(true);
bool DeviceIsDG2OrNewer =
Device->ZeDeviceIpVersionExt->ipVersion >= 0x030dc000;
return ReturnValue(DeviceIsDG2OrNewer &&
Device->ZeDeviceImageProperties->maxImageDims2D > 0);
}
case UR_DEVICE_INFO_IMAGE_PITCH_ALIGN_EXP:
case UR_DEVICE_INFO_MAX_IMAGE_LINEAR_WIDTH_EXP:
Expand Down
Loading