[DeviceSanitizer] Init tracing layer after sanitizer layer to achieve proper tracing #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongreig
approved these changes
Aug 29, 2024
AllanZyne
approved these changes
Sep 2, 2024
Contributor
Author
|
Hi @aarongreig , what should I do to move this PR forward? Thank you. |
pbalcer
approved these changes
Sep 2, 2024
pbalcer
added
ready to merge
Contributor
|
@yingcong-wu CI needs to be green (or mostly green :-)). I restarted it. |
Contributor
Author
|
@pbalcer Sure, thank you. But I just don't see how my PR relates to those failures. I will try to investigate those failures now. |
Contributor
|
@yingcong-wu the remaining failures are unrelated. I'll mark this as ready to merge. |
Contributor
Author
|
Thank you! |
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 11, 2024
UR PR: oneapi-src/unified-runtime#2028 --------- Co-authored-by: Aaron Greig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the tracing layer is inited before sanitizer layer, which means if the sanitizer layer intercepts an API and does not call through layers. The tracing layer will not be able to print the API call.
We should always keep the tracing layer as the last one to be initialized to make sure it is the first layer to handle any API calls so that any API calls would be properly traced.
SYCLOS PR: intel/llvm#15221