Skip to content

Improvements to align CTS and Spec for Adapter #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2024
Merged

Improvements to align CTS and Spec for Adapter #2091

merged 1 commit into from
Sep 27, 2024

Conversation

@martygrant
Copy link
Contributor

@martygrant martygrant commented Sep 13, 2024 •
edited
Loading

  • Add missing error condition to urAdapterGet which is mentioned in its description.
    • Return UR_RESULT_ERROR_INVALID_SIZE when NumEntries == 0 and phAdapters != NULL.
  • Check adapter reference count is updated accordingly after calls to urAdapterRetain/Release.
  • Update urAdapterGetInfo tests
    • ReferenceCountNotZero to check adapter reference count is not 0.
    • ValidAdapterBackend to check UR_ADAPTER_INFO_BACKEND returns a value enumerated in ur_adapter_backend_t.

@martygrant martygrant marked this pull request as ready for review September 13, 2024 15:51
@martygrant martygrant requested a review from a team as a code owner September 13, 2024 15:51
@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification labels Sep 13, 2024
@martygrant martygrant force-pushed the martin/adapter-cts-spec-gap branch from 52696f9 to 4a3741e Compare September 13, 2024 16:38
@kbenzie kbenzie added ready to merge Added to PR's which are ready to merge and removed ready to merge Added to PR's which are ready to merge labels Sep 24, 2024
@kbenzie
Copy link
Contributor

kbenzie commented Sep 24, 2024

There's a couple failing tests when in the Level Zero static job that'll need fixed.

@martygrant
Improvements to align CTS and Spec for Adapter.
de59929 
- Add missing error condition to urAdapterGet which is mentioned in its description.
	- Return UR_RESULT_ERROR_INVALID_SIZE when NumEntries == 0 and phAdapters != NULL.
- Check adapter reference count is updated accordingly after calls to urAdapterRetain/Release.
- Update urAdapterGetInfo tests
	- ReferenceCountNotZero to check adapter reference count is not 0.
	- ValidAdapterBackend to check UR_ADAPTER_INFO_BACKEND returns a value enumerated in ur_adapter_backend_t.
@martygrant martygrant force-pushed the martin/adapter-cts-spec-gap branch from 4a3741e to de59929 Compare September 25, 2024 15:06
@martygrant martygrant mentioned this pull request Sep 25, 2024
Closed
@martygrant martygrant added the ready to merge Added to PR's which are ready to merge label Sep 27, 2024
@aarongreig aarongreig merged commit e824ddc into oneapi-src:main Sep 27, 2024
75 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aarongreig aarongreig aarongreig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

conformance Conformance test suite issues. loader Loader related feature/bug ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martygrant @kbenzie @aarongreig