[DeviceSanitizer] Refactor the code to manage shadow memory #2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
yingcong-wu
reviewed
Sep 25, 2024
AllanZyne
reviewed
Sep 26, 2024
AllanZyne
reviewed
Sep 26, 2024
AllanZyne
approved these changes
Sep 29, 2024
Don't release shadow memory if quarantine is disabled
yingcong-wu
approved these changes
Oct 9, 2024
Contributor
Author
|
Hi @oneapi-src/unified-runtime-maintain, could you please help review this PR? Thanks. |
pbalcer
approved these changes
Oct 10, 2024
Contributor
|
please rebase |
Contributor
Author
Done. The pre-ci failures are unrelated. |
Contributor
Author
|
Hi @pbalcer, could you please raise the priority of merging this PR? We have many other works that will depend on this change. Many thanks. |
Contributor
done, can you please create an intel/llvm PR that updates UR to latest version? |
Contributor
Author
sure, PR created intel/llvm#15736 |
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 17, 2024
UR Part: oneapi-src/unified-runtime#2127 Co-authored-by: Piotr Balcer <[email protected]>
igchor
pushed a commit
to igchor/unified-runtime
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/llvm part: intel/llvm#15736