Skip to content

[DeviceASAN] Fix incorrect symbolizer output for shared libraries #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2024
Merged

[DeviceASAN] Fix incorrect symbolizer output for shared libraries #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d826e6
[DeviceASAN] Fix incorrect symbolizer output for shared libraries
zhaomaosu Oct 22, 2024
817e26c
Minor update
zhaomaosu Oct 22, 2024
2cb803b
Merge branch 'main' into symbolizer-fix-shared-lib
zhaomaosu Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions source/loader/layers/sanitizer/linux/symbolizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
*
*/
#include "common.hpp"
#include "llvm/DebugInfo/Symbolize/DIPrinter.h"
#include "llvm/DebugInfo/Symbolize/Symbolize.h"
#include <link.h>

static llvm::symbolize::PrinterConfig GetPrinterConfig() {
llvm::symbolize::PrinterConfig Config;
Expand All @@ -20,6 +22,28 @@ static llvm::symbolize::PrinterConfig GetPrinterConfig() {
return Config;
}

static uintptr_t GetModuleBase(const char *ModuleName) {
uintptr_t Data = (uintptr_t)ModuleName;
int Result = dl_iterate_phdr(
[](struct dl_phdr_info *Info, size_t, void *Arg) {
uintptr_t *Data = (uintptr_t *)Arg;
const char *ModuleName = (const char *)(*Data);
if (strstr(Info->dlpi_name, ModuleName)) {
*Data = (uintptr_t)Info->dlpi_addr;
return 1;
}
return 0;
},
(void *)&Data);

// If dl_iterate_phdr return 0, it means the module is main executable,
// its base address should be 0.
if (!Result) {
return 0;
}
return Data;
}

extern "C" {

void SymbolizeCode(const char *ModuleName, uint64_t ModuleOffset,
Expand All @@ -38,8 +62,8 @@ void SymbolizeCode(const char *ModuleName, uint64_t ModuleOffset,
llvm::symbolize::LLVMPrinter Printer(OS, EH, Config);

auto ResOrErr = Symbolizer.symbolizeInlinedCode(
ModuleName,
{ModuleOffset, llvm::object::SectionedAddress::UndefSection});
ModuleName, {ModuleOffset - GetModuleBase(ModuleName),
llvm::object::SectionedAddress::UndefSection});

if (!ResOrErr) {
return;
Expand Down
8 changes: 5 additions & 3 deletions source/loader/layers/sanitizer/stacktrace.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
*/

#include "stacktrace.hpp"
#include "asan_interceptor.hpp"
#include "ur_sanitizer_layer.hpp"

extern "C" {
Expand Down Expand Up @@ -92,9 +93,10 @@ void StackTrace::print() const {
BacktraceInfo BI = BacktraceSymbols[i];

// Skip runtime modules
if (Contains(BI, "libsycl.so") ||
Contains(BI, "libpi_unified_runtime.so") ||
Contains(BI, "libur_loader.so")) {
if (!getContext()->interceptor->getOptions().Debug &&
(Contains(BI, "libsycl.so") || Contains(BI, "libur_loader.so") ||
Contains(BI, "libomptarget.rtl.unified_runtime.so") ||
Contains(BI, "libomptarget.so"))) {
continue;
}

Expand Down
Loading