[spec][usm-p2p] p2p info query return int instead of uint32_t, fix l0 impl #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
|
Corresponding DPC++ change here: intel/llvm#15873 |
github-actions
bot
added
specification
pbalcer
approved these changes
Oct 25, 2024
pbalcer
reviewed
Oct 25, 2024
|
L0 Failures are completely unrelated and also occur e.g. here: https://github.com/oneapi-src/unified-runtime/actions/runs/11527149243/job/32093062503?pr=2242 |
sommerlukas
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 31, 2024
There has been some confusion I think originating in the fact that L0 backend returned bool type instead of int for P2P queries. This issue is fixed here oneapi-src/unified-runtime#2246 This PR correspondingly updates the dpc++ runtime. Fixes #15841 --------- Signed-off-by: JackAKirk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The level zero p2p impl currently returns boolean values instead of an integer. This PR fixes that to match the spec requirement.
I've also changed the spec requirement slightly so that all
ur_exp_peer_info_ttypes areintinstead ofuint32_tThe switch to
intpractically makes no real difference right now but I think is an improvement.I think that I made a mistake choosing
uint32_toriginally since in theory the cuda/hip backends could make use of negative values in the future since they useinttype; such that by restricting to an unsigned type we are technically restricting these backends.Also by not specifying a 32 bit type we allow for any unexpected issues where a runtime platform could theoretically use e.g. 16 bit integers as a query return value.
Fixes #2079