[DevAsan] Add an option to enable/disable leak detection #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
loader
AllanZyne
reviewed
Oct 28, 2024
| std::shared_ptr<DeviceInfo> &DeviceInfo); | ||
|
|
||
| private: | ||
| AsanOptions m_Options; |
Contributor
Author
There was a problem hiding this comment.
This is a needed change because we need to make sure AsanOptions destucts after ContextInfo so that we can use it in the ~ContextInfo().
pbalcer
approved these changes
Oct 28, 2024
Contributor
Author
|
Convert this to draft in order to fast-track #2232 . |
Contributor
Author
|
CI fails with apt package installation. Could we restart the CI? |
pbalcer
approved these changes
Nov 25, 2024
AllanZyne
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's better that we have an such option when we need to disable the leak detection.