[DeviceASAN] Simplify shadow mapping logic for GPU device #2274
Conversation
github-actions
bot
added
loader
|
Let's change the mapping logic of DG2 as well? |
Done |
| // Set env AllocateHostAllocationsInHeapExtendedHost to 0, then host and | ||
| // shared usm will have same allocation range on GPU device. This will | ||
| // simplify shadow memory mapping logic on GPU device. | ||
| setenv("NEOReadDebugKeys", "1", 1); |
There was a problem hiding this comment.
@nrspruit is it a good idea to set these env variables in the layer? If this is really required, wouldn't it be a better idea to make this into an L0 API?
Using a debug key for functionality doesn't seem like a good idea.
There was a problem hiding this comment.
I don't feel comfortable merging this patch. We need confirmation from the NEO folks that this makes sense.
@MichalMrozek can you help?
There was a problem hiding this comment.
No, this is not correct to set this.
Please do not merge it.
If you want to have specific release keys avaialable this needs discussion with driver team.
There was a problem hiding this comment.
AllocateHostAllocationsInHeapExtendedHost is a debug key, debug keys cannot be used in production software. They are meant only for experiments. Driver team may remove or change this debug variable at any point of time without any notifications.
There was a problem hiding this comment.
Ok, I will send this request to driver team. Thanks.
kbenzie
added
v0.11.x
|
I'll try to find other optimization opportunity. I'm closing this PR. |
6 participants
intel/llvm part: intel/llvm#15954