[Spec] fix urKernelSuggestMaxCooperativeGroupCountExp #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
force-pushed
the
cooperative_fix
branch
from
0a8ccf1 to
1c91bbd
Compare
github-actions
bot
added
loader
GeorgeWeb
reviewed
Nov 1, 2024
igchor
force-pushed
the
cooperative_fix
branch
from
1c91bbd to
43aa821
Compare
|
Testing PR to intel/llvm: intel/llvm#15966 |
pbalcer
approved these changes
Nov 4, 2024
|
this needs rebasing. @oneapi-src/unified-runtime-opencl-write please review |
aarongreig
approved these changes
Dec 13, 2024
Add extra param: ur_device_handle_t It is necessary to implement this function on L0 for kernels that are build for multiple devices. Right now, the implementation only works when the kernel is created from a native handle. Ref: oneapi-src#2262
igchor
force-pushed
the
cooperative_fix
branch
from
43aa821 to
4a89e1c
Compare
Done. |
|
v2 tests failed, but that doesn't seem related. |
intel/llvm#15966 is approved. |
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Dec 19, 2024
…15966) Ref: oneapi-src/unified-runtime#2277 --------- Co-authored-by: Martin Morrison-Grant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra param: ur_device_handle_t
It is necessary to implement this function on L0 for kernels that are build for multiple devices. Right now, the implementation only works when the kernel is created from a native handle.
Ref: #2262