Skip to content

Conversation

@nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Nov 8, 2024

  • As of v1.10 of the L0 spec, zeInit and zeDriverGet is the old init pathway and the desired init api is zeInitDrivers. This new api allows for multi heterogenous drivers to coexist in a single L0 Process.

@github-actions github-actions bot added the level-zero L0 adapter specific issues label Nov 8, 2024
@nrspruit nrspruit force-pushed the zeInitDrivers branch 8 times, most recently from 42b88fb to 57e5857 Compare November 9, 2024 00:36
@github-actions github-actions bot added the ci/cd Continuous integration/devliery label Nov 13, 2024
@nrspruit nrspruit force-pushed the zeInitDrivers branch 2 times, most recently from 50789b1 to 8525dd3 Compare November 13, 2024 22:31
@nrspruit
Copy link
Contributor Author

@nrspruit This is marked ready to merge but two L0 jobs have failed (not counting the E2E tests) - are these failures expected?

@callumfare the errors are unrelated and fail sporadically in multiple PRs.

I can rebase and repush the changes to see if I can clear it out. I will remove the read to merge until that is complete.

@nrspruit nrspruit removed the ready to merge Added to PR's which are ready to merge label Nov 21, 2024
@nrspruit nrspruit force-pushed the zeInitDrivers branch 3 times, most recently from c9b5659 to 40507b8 Compare November 21, 2024 21:10
@nrspruit
Copy link
Contributor Author

@winstonzhang-intel , I found a couple of things that I needed to change, can you re-review?

@nrspruit nrspruit force-pushed the zeInitDrivers branch 4 times, most recently from 31e24a8 to ac68e10 Compare November 22, 2024 00:01
@nrspruit
Copy link
Contributor Author

@callumfare , I will need @pbalcer's help to determine why only the static lib no platform test is hanging when it passes everywhere else.

@nrspruit
Copy link
Contributor Author

@callumfare , I will need @pbalcer's help to determine why only the static lib no platform test is hanging when it passes everywhere else.

Based off an offline discussion, because the loader test error for loader_platform_test_no_platforms cannot be reproduced elsewhere we are disabling it until the issues with ctest can be worked out.

- As of v1.10 of the L0 spec, zeInit and zeDriverGet is the old init
  pathway and the desired init api is zeInitDrivers. This new api allows
for multi heterogenous drivers to coexist in a single L0 Process.

Signed-off-by: Neil R. Spruit <[email protected]>
@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Nov 22, 2024
@nrspruit nrspruit removed the ready to merge Added to PR's which are ready to merge label Nov 22, 2024
@nrspruit
Copy link
Contributor Author

There was a race condition in the code, I have re-enabled the test that was failing on windows to see if that change fixes the issue. If so, then I will add back in the ready_to_merge, awaiting update of the CI results to be sure.

nrspruit added a commit to nrspruit/llvm that referenced this pull request Nov 23, 2024
@nrspruit
Copy link
Contributor Author

There was a race condition in the code, I have re-enabled the test that was failing on windows to see if that change fixes the issue. If so, then I will add back in the ready_to_merge, awaiting update of the CI results to be sure.

the fix to the code did not address the race condition with the loader no platforms test, I disabled the test again. Once the CI finishes I will add the ready_to_merge label again since this has been reviewed again offline.

@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Nov 23, 2024
@nrspruit
Copy link
Contributor Author

Based off the intel/llvm CI result here: intel/llvm#16034 and the updated results in the CI, this is ready to merge again.

The failures in the e2e CI in UR are unrelated and have been seen before.

@callumfare callumfare merged commit 38ee6ce into oneapi-src:main Nov 25, 2024
74 of 75 checks passed
martygrant pushed a commit to intel/llvm that referenced this pull request Nov 25, 2024
-pre-commit PR for
oneapi-src/unified-runtime#2303

---------

Signed-off-by: Neil R. Spruit <[email protected]>
Co-authored-by: Callum Fare <[email protected]>
@kbenzie kbenzie added the v0.11.x Include in the v0.11.x release label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Continuous integration/devliery level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants