-
Notifications
You must be signed in to change notification settings - Fork 124
[L0] Implement Support for zeInitDrivers #2303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nrspruit
commented
Nov 8, 2024
- As of v1.10 of the L0 spec, zeInit and zeDriverGet is the old init pathway and the desired init api is zeInitDrivers. This new api allows for multi heterogenous drivers to coexist in a single L0 Process.
b55be89 to
16ded3f
Compare
16ded3f to
61badcb
Compare
42b88fb to
57e5857
Compare
57e5857 to
4b00dc2
Compare
4b00dc2 to
3e64ac8
Compare
3e64ac8 to
76dbfeb
Compare
76dbfeb to
81f0633
Compare
50789b1 to
8525dd3
Compare
8525dd3 to
72e9cb0
Compare
72e9cb0 to
6cce104
Compare
@callumfare the errors are unrelated and fail sporadically in multiple PRs. I can rebase and repush the changes to see if I can clear it out. I will remove the read to merge until that is complete. |
c9b5659 to
40507b8
Compare
|
@winstonzhang-intel , I found a couple of things that I needed to change, can you re-review? |
31e24a8 to
ac68e10
Compare
|
@callumfare , I will need @pbalcer's help to determine why only the static lib no platform test is hanging when it passes everywhere else. |
70e8fc3 to
298a001
Compare
Based off an offline discussion, because the loader test error for loader_platform_test_no_platforms cannot be reproduced elsewhere we are disabling it until the issues with ctest can be worked out. |
- As of v1.10 of the L0 spec, zeInit and zeDriverGet is the old init pathway and the desired init api is zeInitDrivers. This new api allows for multi heterogenous drivers to coexist in a single L0 Process. Signed-off-by: Neil R. Spruit <[email protected]>
298a001 to
a3984e2
Compare
Signed-off-by: Neil R. Spruit <[email protected]>
a3984e2 to
2a580bf
Compare
|
There was a race condition in the code, I have re-enabled the test that was failing on windows to see if that change fixes the issue. If so, then I will add back in the ready_to_merge, awaiting update of the CI results to be sure. |
Signed-off-by: Neil R. Spruit <[email protected]>
-pre-commit PR for oneapi-src/unified-runtime#2303 Signed-off-by: Neil R. Spruit <[email protected]>
the fix to the code did not address the race condition with the loader no platforms test, I disabled the test again. Once the CI finishes I will add the ready_to_merge label again since this has been reviewed again offline. |
|
Based off the intel/llvm CI result here: intel/llvm#16034 and the updated results in the CI, this is ready to merge again. The failures in the e2e CI in UR are unrelated and have been seen before. |
-pre-commit PR for oneapi-src/unified-runtime#2303 --------- Signed-off-by: Neil R. Spruit <[email protected]> Co-authored-by: Callum Fare <[email protected]>