[CUDA][HIP][CommandBuffer] Add try catches to anything that can throw #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cuda
EwanC
approved these changes
Nov 18, 2024
|
@hdelan this PR has a conflict, if you could resolve that I'll get this merged today :) |
UR_CHECK_ERROR must be called within a try catch block, as it can throw. For functions that don't return a `ur_result_handle_t`, and which might throw, make sure these funcs are only called within try catches in the caller funcs, and that they are not exposed to the user.
|
Thanks @martygrant have rebased. |
|
This will get pulled in as part of intel/llvm#15965 |
martygrant
added a commit
to martygrant/llvm
that referenced
this pull request
Dec 12, 2024
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR_CHECK_ERRORmust be called within a try catch block, as it can throw.For functions that don't return a
ur_result_handle_t, and which might throw, make sure these funcs are only called within try catches in the caller funcs, and that they are not exposed to the user.DPC++ PR: intel/llvm#16105