[CUDA] Fix potential issue with command buffer fills on CUDA #2425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
Dec 5, 2024
Bensuo
commented
- Fix a potential issue where decomposed fill nodes for large patterns would overwrite external event dependencies provided by the user when stored in a command handle, this could lead to an error when events were updatd.
- Also store decomposed nodes in fill command handles for future use when updating.
- Add missing event_sync tests with and without event update for large pattern fills (> 4 bytes)
github-actions
bot
added
conformance
EwanC
reviewed
Dec 5, 2024
Bensuo
force-pushed
the
ben/cuda-event-fix
branch
from
ce492f5 to
bd76ef6
Compare
EwanC
approved these changes
Dec 9, 2024
Contributor
Author
|
DPC++ PR: intel/llvm#16305 |
Contributor
|
@Bensuo got 2 failing jobs, might need an update to the match files possibly? |
Bensuo
force-pushed
the
ben/cuda-event-fix
branch
from
bd76ef6 to
7efa7be
Compare
- Fix a potential issue where decomposed fill nodes for large patterns would overwrite external event dependencies provided by the user when stored in a command handle - Also store decomposed nodes in fill command handles for future use when updating. - Add missing event_sync tests for large pattern fills (> 4 bytes)
Bensuo
force-pushed
the
ben/cuda-event-fix
branch
from
7efa7be to
76054dd
Compare
Contributor
Author
|
@martygrant Sorry for the delay, match files are now updated and this should be good to go again. |
Contributor
|
@Bensuo no problem, cheers! |
martygrant
added a commit
to nrspruit/llvm
that referenced
this pull request
Dec 19, 2024
Contributor
|
Pulled in with intel/llvm#16410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.