Fix L0 command-buffer consumption of multi-device kernels #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
level-zero
EwanC
pushed a commit
to reble/llvm
that referenced
this pull request
Dec 12, 2024
Bumps UR commit to oneapi-src/unified-runtime#2454 which contains a fix for using kernel bundles associated with a multi-device context in a SYCL-Graph
EwanC
force-pushed
the
l0_cmd-buf_multi-device
branch
from
0b0295c to
f0facdb
Compare
EwanC
force-pushed
the
l0_cmd-buf_multi-device
branch
2 times, most recently
from
434cf05 to
583af28
Compare
EwanC
force-pushed
the
l0_cmd-buf_multi-device
branch
from
583af28 to
352af52
Compare
fabiomestre
approved these changes
Dec 13, 2024
aarongreig
reviewed
Dec 13, 2024
|
|
||
| static bool hasCommandBufferSupport(ur_device_handle_t device) { | ||
| size_t returned_size; | ||
| auto res = urDeviceGetInfo(device, UR_DEVICE_INFO_EXTENSIONS, 0, |
Contributor
There was a problem hiding this comment.
can we use UR_DEVICE_INFO_COMMAND_BUFFER_SUPPORT_EXP here instead?
Contributor
Author
There was a problem hiding this comment.
yes, updated (really need to get #2304 merged 😉 )
kbenzie
approved these changes
Dec 13, 2024
| }; | ||
|
|
||
| TEST_F(urMultiDeviceCommandBufferExpTest, Enqueue) { | ||
| for (size_t i = 0; i < devices.size(); i++) { |
Contributor
There was a problem hiding this comment.
@aarongreig FYI these test will need updated in your CTS multi-platform/device branch.
UR program and kernel objects can be tied to multiple devices, a UR command-buffer object however is tied to a single device. When appending a kernel command to a command-buffer, select the correct single-device `ze_kernel_handle_t` object from the multi-device `ur_kernel_handle_t` object
EwanC
force-pushed
the
l0_cmd-buf_multi-device
branch
from
352af52 to
fcddf07
Compare
martygrant
added a commit
to reble/llvm
that referenced
this pull request
Dec 13, 2024
martygrant
added a commit
to intel/llvm
that referenced
this pull request
Dec 13, 2024
Bumps UR commit to oneapi-src/unified-runtime#2454 which contains a fix for using kernel bundles associated with a multi-device context in a SYCL-Graph --------- Co-authored-by: Martin Morrison-Grant <[email protected]>
kbenzie
pushed a commit
that referenced
this pull request
Dec 16, 2024
Fix L0 command-buffer consumption of multi-device kernels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UR program and kernel objects can be tied to multiple devices, a UR command-buffer object however is tied to a single device.
When appending a kernel command to a command-buffer, select the correct single-device
ze_kernel_handle_tobject from the multi-deviceur_kernel_handle_tobjectDPC++ PR intel/llvm#16343