Skip to content

Use autoconf 2.72 for ruby 3.4 and head (gcc 15)#26

Merged
larskanis merged 1 commit intooneclick:masterfrom
ntkme:autoconf
May 18, 2025
Merged

Use autoconf 2.72 for ruby 3.4 and head (gcc 15)#26
larskanis merged 1 commit intooneclick:masterfrom
ntkme:autoconf

Conversation

@ntkme
Copy link
Contributor

@ntkme ntkme commented May 16, 2025

We can either do WANT_AUTOCONF='2.72' autoreconf -fi or do a patch like this PR. The reason I choose to use a patch is that it's more explicit, and the patch will fail when upstream catchup so that we will know when to revert the patch.

Regarding how autoconf version is picked: https://www.msys2.org/docs/autotools/

If WANT_AUTOCONF is not defined, it searches version string in existing configure. Therefore we can patch configure to force it pick a different version.

@ntkme ntkme changed the title Use autoconf 2.72 for ruby 3.4 and head Use autoconf 2.72 for ruby 3.4 and head (gcc 15) May 16, 2025
@ntkme
Copy link
Contributor Author

ntkme commented May 16, 2025

To confirm that this is working - before the patch the build log has:

  checking for stdbool.h that conforms to C99... no

after the patch the build log has:

  checking for stdbool.h that conforms to C99 or later... yes

@larskanis
Copy link
Member

I noticed the stdbool error somewhere before the release, but forgot about it, unfotunatelly. Great work however! Will make a new release tomorrow. After adding a test case.

@MSP-Greg
Copy link
Contributor

Thanks to both of you for this.

Reminder, I believe backports are being done, so 3.2.9 and 3.3.9 may need the same change.

@larskanis larskanis merged commit 7af75f6 into oneclick:master May 18, 2025
0 of 3 checks passed
@ntkme ntkme deleted the autoconf branch May 18, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C23 bool/stdbool broken on 3.4.4 and head

3 participants