Use autoconf 2.72 for ruby 3.4 and head (gcc 15)#26
Merged
larskanis merged 1 commit intooneclick:masterfrom May 18, 2025
ntkme:autoconf
Merged
Use autoconf 2.72 for ruby 3.4 and head (gcc 15)#26larskanis merged 1 commit intooneclick:masterfrom ntkme:autoconf
larskanis merged 1 commit intooneclick:masterfrom
ntkme:autoconf
Conversation
Contributor
Author
|
To confirm that this is working - before the patch the build log has: after the patch the build log has: |
Member
|
I noticed the stdbool error somewhere before the release, but forgot about it, unfotunatelly. Great work however! Will make a new release tomorrow. After adding a test case. |
Contributor
|
Thanks to both of you for this. Reminder, I believe backports are being done, so 3.2.9 and 3.3.9 may need the same change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can either do
WANT_AUTOCONF='2.72' autoreconf -fior do a patch like this PR. The reason I choose to use a patch is that it's more explicit, and the patch will fail when upstream catchup so that we will know when to revert the patch.Regarding how autoconf version is picked: https://www.msys2.org/docs/autotools/
If WANT_AUTOCONF is not defined, it searches version string in existing
configure. Therefore we can patchconfigureto force it pick a different version.