Allow pre-emptive specification of OTP with push#81
Allow pre-emptive specification of OTP with push#81nneul wants to merge 1 commit intoonelogin:masterfrom
Conversation
If you provide OTP on CLI, this will include it with the first attempted push automatically, negating need to respond if it's already correct.
|
It looks like a useful feature, but this code change makes the code misleading as it is nested within the OneLogin Protect branch. Currently the assumption is that if you're using OneLogin Protect, you want to use the push notifications, which it wouldn't make sense to take a CLI OTP for. We do not want to further obfuscate this code and add tech debt to this repo that will need to be changed later. As this is a useful feature, we made our own stab at it here #82 so that the code isn't misleading. But we'd need more tests to make a change like this. We've put it in our issue tracker, but it may take a while, though if you need this fast you can try and write them. Or a possible workaround is to use something other than OneLogin Protect for OTP. |
If you provide OTP on CLI, this will include it with the first attempted push automatically, negating need to respond if it's already correct.