improve grpc converter tests #8208
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive tests for all previously untested conversion and validation functions.
mts1715
requested review from
AndriiDiachuk,
UlyanaAndrukhiv,
illia-malachyn and
peterargue
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
UlyanaAndrukhiv
left a comment
UlyanaAndrukhiv
left a comment
There was a problem hiding this comment.
Overall, looks good! I’ve left a few suggestions for improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8127 #8241
test: achieve 100% test coverage for engine/common/rpc/convert package
Add comprehensive tests for all previously untested conversion and validation
functions.
Changes: